]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
Staging: bcm: CmHost: moved and removed declarations and tmp bracing.
authorGary Rookard <garyrookard@gmail.com>
Tue, 18 Mar 2014 20:17:28 +0000 (16:17 -0400)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 18 Mar 2014 23:22:27 +0000 (16:22 -0700)
commit3c13b046d5d77fad6fc0f79ac382089b8ad1b6c3
tree92ff73351bb86dca7558c1ffba7dde1251add899
parentfd54889b65cc32fc64e5a6c456fbf6aab4bd258a
Staging: bcm: CmHost: moved and removed declarations and tmp bracing.

Firstly, some background is needed to confirm the validity of
this patch as error fixing. It seems the developer when writing
this driver from scratch, used what are known to me as error
suppressors in the form of extra tmp bracing added to the case labels.
They aid during construction time, but are not intended to remain.

In this scenario there are declarations occupying space only
reserved for statements. If these tmp braces were to be removed
before the declarations in question were reassigned to there
proper place in the funtion, compile time errors would result.

So, having that said, I moved the declarations,
UINT uiSearchRuleIndex = 0; and ULONG ulSFID;,
and also deleted the duplicates thereof from
the switch/case statement.

Removed temporary bracing from case labels.

Removed new lines as needed.

Properly indented case breaks.

Added /* FALLTHROUGH */ comments to switch/case.

Signed-off-by: Gary Rookard <garyrookard@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/bcm/CmHost.c