]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
dmaengine: timb_dma: Use struct_size() in kzalloc()
authorGustavo A. R. Silva <gustavo@embeddedor.com>
Tue, 8 Jan 2019 15:58:52 +0000 (09:58 -0600)
committerVinod Koul <vkoul@kernel.org>
Sun, 20 Jan 2019 05:20:07 +0000 (10:50 +0530)
commit3c215fd868dd9fe077af63dbddca585e5116f598
treeafa8d3176df3c36c42ed288932ee2e6e2c8e654b
parent73bf95f57bcfe4a91771cbf43405ec7e14f382c5
dmaengine: timb_dma: Use struct_size() in kzalloc()

One of the more common cases of allocation size calculations is finding the
size of a structure that has a zero-sized array at the end, along with memory
for some number of elements for that array. For example:

struct foo {
    int stuff;
    void *entry[];
};

instance = kzalloc(sizeof(struct foo) + sizeof(void *) * count, GFP_KERNEL);

Instead of leaving these open-coded and prone to type mistakes, we can now
use the new struct_size() helper:

instance = kzalloc(struct_size(instance, entry, count), GFP_KERNEL);

This code was detected with the help of Coccinelle.

Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
Signed-off-by: Vinod Koul <vkoul@kernel.org>
drivers/dma/timb_dma.c