]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bnxt_en: avoid string overflow for record->system_name
authorArnd Bergmann <arnd@arndb.de>
Mon, 13 Aug 2018 21:26:54 +0000 (23:26 +0200)
committerDavid S. Miller <davem@davemloft.net>
Tue, 14 Aug 2018 03:45:49 +0000 (20:45 -0700)
commit3d46eee5a5f2f22ca04e2139e8c9a16b81d16073
tree7dcee612e1a179b883cbe0913d73b8db973781da
parent9dc502d79778324df7db4e093ffddf5413a1cd5f
bnxt_en: avoid string overflow for record->system_name

The utsname()->nodename string may be 64 bytes long, and it gets
copied without the trailing nul byte into the shorter record->system_name,
as gcc now warns:

In file included from include/linux/bitmap.h:9,
                 from include/linux/ethtool.h:16,
                 from drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:13:
In function 'strncpy',
    inlined from 'bnxt_fill_coredump_record' at drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c:2863:2:
include/linux/string.h:254:9: error: '__builtin_strncpy' output truncated before terminating nul copying as many bytes from a string as its length [-Werror=stringop-truncation]

Using strlcpy() at least avoids overflowing the destination buffer
and adds proper nul-termination. It may still truncate long names
though, which probably can't be solved here.

Fixes: 6c5657d085ae ("bnxt_en: Add support for ethtool get dump.")
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Michael Chan <michael.chan@broadcom.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/broadcom/bnxt/bnxt_ethtool.c