]> git.proxmox.com Git - libgit2.git/commit
Revert "object: correct the expected ID size in prefix lookup"
authorVicent Marti <tanoku@gmail.com>
Fri, 26 Jun 2015 14:45:42 +0000 (16:45 +0200)
committerVicent Marti <tanoku@gmail.com>
Fri, 26 Jun 2015 14:45:42 +0000 (16:45 +0200)
commit3d9ef2dc1befc9c63654633d3c714e11df85ddbc
tree3d954cb9fbaf0bd8be08557aabd2dddd78982d56
parent14888070b941824b7f6369c60d7600594d215577
Revert "object: correct the expected ID size in prefix lookup"

This reverts commit 969d4b703c910a8fd045baafbcd243b4c9825316.

This was a fluke from Coverity. The length to all the APIs in the
library is supposed to be passed in as nibbles, not bytes. Passing it as
bytes would prevent us from parsing uneven-sized SHA1 strings.

Also, the rest of the library was still using nibbles (including
revparse and the odb_prefix APIs), so this change was seriously breaking
things in unexpected ways. ^^
src/object.c