]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
media: tw5864: check status of tw5864_frameinterval_get
authorTom Rix <trix@redhat.com>
Mon, 10 Aug 2020 19:25:18 +0000 (21:25 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Thu, 10 Dec 2020 11:02:48 +0000 (12:02 +0100)
commit3de4edc57f9bce67b565ebc932d6c3307f1fa22a
treec223bf8ca9e052767a3b065503e67062c1209e25
parentbd98a87d38278f18a981faa1adf1f3608aaeda7d
media: tw5864: check status of tw5864_frameinterval_get

BugLink: https://bugs.launchpad.net/bugs/1904450
[ Upstream commit 780d815dcc9b34d93ae69385a8465c38d423ff0f ]

clang static analysis reports this problem

tw5864-video.c:773:32: warning: The left expression of the compound
  assignment is an uninitialized value.
  The computed value will also be garbage
        fintv->stepwise.max.numerator *= std_max_fps;
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ^

stepwise.max is set with frameinterval, which comes from

ret = tw5864_frameinterval_get(input, &frameinterval);
fintv->stepwise.step = frameinterval;
fintv->stepwise.min = frameinterval;
fintv->stepwise.max = frameinterval;
fintv->stepwise.max.numerator *= std_max_fps;

When tw5864_frameinterval_get() fails, frameinterval is not
set. So check the status and fix another similar problem.

Signed-off-by: Tom Rix <trix@redhat.com>
Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
Signed-off-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: William Breathitt Gray <william.gray@canonical.com>
drivers/media/pci/tw5864/tw5864-video.c