]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
workqueue: clear POOL_DISASSOCIATED in rebind_workers()
authorLai Jiangshan <laijs@cn.fujitsu.com>
Tue, 3 Jun 2014 07:33:27 +0000 (15:33 +0800)
committerTejun Heo <tj@kernel.org>
Tue, 1 Jul 2014 21:40:14 +0000 (17:40 -0400)
commit3de5e88485b22f30403045bd83d4815ae2207b19
tree8b771a4cad4308843bbb0f5898ed7791823215bb
parent92b69f509196fc5afc6a357511b864d372f42419
workqueue: clear POOL_DISASSOCIATED in rebind_workers()

a9ab775bcadf ("workqueue: directly restore CPU affinity of workers
from CPU_ONLINE") moved pool locking into rebind_workers() but left
"pool->flags &= ~POOL_DISASSOCIATED" in workqueue_cpu_up_callback().

There is nothing necessarily wrong with it, but there is no benefit
either.  Let's move it into rebind_workers() and achieve the following
benefits:

  1) better readability, POOL_DISASSOCIATED is cleared in rebind_workers()
     as expected.

  2) we can guarantee that, when POOL_DISASSOCIATED is clear, the
     running workers of the pool are on the local CPU (pool->cpu).

tj: Minor description update.

Signed-off-by: Lai Jiangshan <laijs@cn.fujitsu.com>
Signed-off-by: Tejun Heo <tj@kernel.org>
kernel/workqueue.c