]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
drm/msm/a3xx: fix error handling in a3xx_gpu_init()
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 1 Oct 2021 12:59:04 +0000 (15:59 +0300)
committerRob Clark <robdclark@chromium.org>
Tue, 12 Oct 2021 00:30:53 +0000 (17:30 -0700)
commit3eda901995371d390ef82d0b6462f4ea8efbcfdf
tree9b770d400f505d2b2308166aa5352cd58fd1992a
parent980d74e7d03ccf2eaa11d133416946bd880c7c08
drm/msm/a3xx: fix error handling in a3xx_gpu_init()

These error paths returned 1 on failure, instead of a negative error
code.  This would lead to an Oops in the caller.  A second problem is
that the check for "if (ret != -ENODATA)" did not work because "ret" was
set to 1.

Fixes: 5785dd7a8ef0 ("drm/msm: Fix duplicate gpu node in icc summary")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Link: https://lore.kernel.org/r/20211001125904.GK2283@kili
Signed-off-by: Rob Clark <robdclark@chromium.org>
drivers/gpu/drm/msm/adreno/a3xx_gpu.c