]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net: openvswitch: don't send internal clone attribute to the userspace.
authorIlya Maximets <i.maximets@ovn.org>
Mon, 4 Apr 2022 10:41:50 +0000 (12:41 +0200)
committerJakub Kicinski <kuba@kernel.org>
Wed, 6 Apr 2022 00:57:54 +0000 (17:57 -0700)
commit3f2a3050b4a3e7f32fc0ea3c9b0183090ae00522
tree8ccedded15b8c2872c40ee194439d60d95dfc348
parent1d7e4fd72bb9be080c23a099b0dff1007109fc2b
net: openvswitch: don't send internal clone attribute to the userspace.

'OVS_CLONE_ATTR_EXEC' is an internal attribute that is used for
performance optimization inside the kernel.  It's added by the kernel
while parsing user-provided actions and should not be sent during the
flow dump as it's not part of the uAPI.

The issue doesn't cause any significant problems to the ovs-vswitchd
process, because reported actions are not really used in the
application lifecycle and only supposed to be shown to a human via
ovs-dpctl flow dump.  However, the action list is still incorrect
and causes the following error if the user wants to look at the
datapath flows:

  # ovs-dpctl add-dp system@ovs-system
  # ovs-dpctl add-flow "<flow match>" "clone(ct(commit),0)"
  # ovs-dpctl dump-flows
  <flow match>, packets:0, bytes:0, used:never,
    actions:clone(bad length 4, expected -1 for: action0(01 00 00 00),
                  ct(commit),0)

With the fix:

  # ovs-dpctl dump-flows
  <flow match>, packets:0, bytes:0, used:never,
    actions:clone(ct(commit),0)

Additionally fixed an incorrect attribute name in the comment.

Fixes: b233504033db ("openvswitch: kernel datapath clone action")
Signed-off-by: Ilya Maximets <i.maximets@ovn.org>
Acked-by: Aaron Conole <aconole@redhat.com>
Link: https://lore.kernel.org/r/20220404104150.2865736-1-i.maximets@ovn.org
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
net/openvswitch/actions.c
net/openvswitch/flow_netlink.c