]> git.proxmox.com Git - ovs.git/commit
dpif-netdev: Fail port addition if reconfiguration failed.
authorIlya Maximets <i.maximets@samsung.com>
Mon, 22 Jul 2019 14:56:50 +0000 (17:56 +0300)
committerIlya Maximets <i.maximets@samsung.com>
Thu, 29 Aug 2019 15:25:50 +0000 (18:25 +0300)
commit3f51ea180ba1183aed9912aa48b7f0e6de3b578d
treeb48f6e89bfddb87329b58c0460c9d2d13bdcdd63
parent5c56607200c3c345efe7d79b148b5ffa22bb5bc2
dpif-netdev: Fail port addition if reconfiguration failed.

If the port was destroyed during the initial reconfiguration, we should
report an error to the upper layers. Otherwise, successful addition of
the port will be logged and upper layers will continue to configure
this port. For example, the 'dpif' layer will try to initilaize flow
API for this device.

Fix that by checking for port existence after reconfiguration. We can't
get the real error code here, so let's assume EINVAL. 'ovs-vsctl' will
tell the user to check the logs for a real reason anyway.

Fixes: e32971b8ddb4 ("dpif-netdev: Centralized threads and queues handling code.")
Signed-off-by: Ilya Maximets <i.maximets@samsung.com>
Acked-by: Ian Stokes <ian.stokes@intel.com>
lib/dpif-netdev.c