]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
PCI: dwc: Move interrupt acking into the proper callback
authorMarc Zyngier <marc.zyngier@arm.com>
Tue, 13 Nov 2018 22:57:34 +0000 (22:57 +0000)
committerLorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Tue, 11 Dec 2018 10:37:58 +0000 (10:37 +0000)
commit3f7bb2ec20ce07c02b2002349d256c91a463fcc5
tree6ac71be7712de7854c078116debcefb34fbcd6aa
parentfce5423e4f431c71933d6c1f850b540a314aa6ee
PCI: dwc: Move interrupt acking into the proper callback

The write to the status register is really an ACK for the HW,
and should be treated as such by the driver. Let's move it to the
irq_ack() callback, which will prevent people from moving it around
in order to paper over other bugs.

Fixes: 8c934095fa2f ("PCI: dwc: Clear MSI interrupt status after it is handled,
not before")
Fixes: 7c5925afbc58 ("PCI: dwc: Move MSI IRQs allocation to IRQ domains
hierarchical API")
Link: https://lore.kernel.org/linux-pci/20181113225734.8026-1-marc.zyngier@arm.com/
Reported-by: Trent Piepho <tpiepho@impinj.com>
Tested-by: Niklas Cassel <niklas.cassel@linaro.org>
Tested-by: Gustavo Pimentel <gustavo.pimentel@synopsys.com>
Tested-by: Stanimir Varbanov <svarbanov@mm-sol.com>
Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
[lorenzo.pieralisi@arm.com: updated commit log]
Signed-off-by: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: stable@vger.kernel.org
drivers/pci/controller/dwc/pcie-designware-host.c