]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
USB: serial: omninet: fix reference leaks at open
authorJohan Hovold <johan@kernel.org>
Mon, 6 Mar 2017 16:36:38 +0000 (17:36 +0100)
committerTim Gardner <tim.gardner@canonical.com>
Mon, 20 Mar 2017 11:24:55 +0000 (05:24 -0600)
commit3fc5a49a211df1f20298e78aae07abbe961e4d10
treefd5736b909322660609d02b4b7b05b6c55826ed0
parent7c33b84a5785acbdc359de23497e577c080c6f5d
USB: serial: omninet: fix reference leaks at open

BugLink: http://bugs.launchpad.net/bugs/1674288
commit 30572418b445d85fcfe6c8fe84c947d2606767d8 upstream.

This driver needlessly took another reference to the tty on open, a
reference which was then never released on close. This lead to not just
a leak of the tty, but also a driver reference leak that prevented the
driver from being unloaded after a port had once been opened.

Fixes: 4a90f09b20f4 ("tty: usb-serial krefs")
Signed-off-by: Johan Hovold <johan@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/usb/serial/omninet.c