]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drivers/rtc/rtc-pcf8563.c: fix pcf8563_irq() error return value
authorArnd Bergmann <arnd@arndb.de>
Mon, 13 Oct 2014 22:53:10 +0000 (15:53 -0700)
committerLinus Torvalds <torvalds@linux-foundation.org>
Tue, 14 Oct 2014 00:18:19 +0000 (02:18 +0200)
commit3ff38237f183ecd8a190318e0046138b92ee5e35
treed07c9e7c8078fb36f6c5c6e2fcc572e57ce14ee7
parente698a51239f26c370247d759da9ea016f5841fc3
drivers/rtc/rtc-pcf8563.c: fix pcf8563_irq() error return value

As pointed out by Sergei Shtylyov, the pcf8563_irq function contains a
bug in the error handling: an interrupt handler is not supposed to
return an errno value but an 'enum irqreturn'.

Let's fix this by returning IRQ_NONE in case of a communication error.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Cc: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Alessandro Zummo <a.zummo@towertech.it>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
drivers/rtc/rtc-pcf8563.c