]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
x86/hyper-v: Fix overflow bug in fill_gva_list()
authorTianyu Lan <Tianyu.Lan@microsoft.com>
Mon, 2 Sep 2019 12:41:43 +0000 (20:41 +0800)
committerIngo Molnar <mingo@kernel.org>
Mon, 2 Sep 2019 17:57:19 +0000 (19:57 +0200)
commit4030b4c585c41eeefec7bd20ce3d0e100a0f2e4d
tree7690ee68cc3ce82fba4c4410d601cf999b68cc72
parent9b8bd476e78e89c9ea26c3b435ad0201c3d7dbf5
x86/hyper-v: Fix overflow bug in fill_gva_list()

When the 'start' parameter is >=  0xFF000000 on 32-bit
systems, or >= 0xFFFFFFFF'FF000000 on 64-bit systems,
fill_gva_list() gets into an infinite loop.

With such inputs, 'cur' overflows after adding HV_TLB_FLUSH_UNIT
and always compares as less than end.  Memory is filled with
guest virtual addresses until the system crashes.

Fix this by never incrementing 'cur' to be larger than 'end'.

Reported-by: Jong Hyun Park <park.jonghyun@yonsei.ac.kr>
Signed-off-by: Tianyu Lan <Tianyu.Lan@microsoft.com>
Reviewed-by: Michael Kelley <mikelley@microsoft.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Fixes: 2ffd9e33ce4a ("x86/hyper-v: Use hypercall for remote TLB flush")
Signed-off-by: Ingo Molnar <mingo@kernel.org>
arch/x86/hyperv/mmu.c