]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
team: bcast: convert return value of team_dev_queue_xmit() to bool correctly
authorJiri Pirko <jiri@resnulli.us>
Wed, 21 Nov 2012 02:34:45 +0000 (02:34 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 21 Nov 2012 16:55:07 +0000 (11:55 -0500)
commit403f43c937d24832b18524f65415c0bbba6b5064
treed4200f7ab5fc11ad0ca71cc11ce22e8e3ed4773b
parent0e376bd0b791ac6ac6bdb051492df0769c840848
team: bcast: convert return value of team_dev_queue_xmit() to bool correctly

The thing is that team_dev_queue_xmit() returns NET_XMIT_* or -E*.
bc_trasmit() should return true in case all went well. So use ! to get
correct retval from team_dev_queue_xmit() result.
This bug caused iface statistics to be badly computed.

This bug was introduced by:
team: add broadcast mode (5fc889911a99043a97da1daa0d010ad72cbc3042)

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Jiri Pirko <jiri@resnulli.us>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/team/team_mode_broadcast.c