]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/i915: Swap ret and status returned from skl_pcode_request
authorStanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Mon, 11 Apr 2022 08:13:43 +0000 (11:13 +0300)
committerStanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Mon, 11 Apr 2022 13:47:08 +0000 (16:47 +0300)
commit40a56956e55a766622c35106a510c10a105436b4
treec270f858eee8550a11d8433ee185a1fc98f227d3
parent9e0a1c3c3fcbf9d819d1ee584e43c87318772fdc
drm/i915: Swap ret and status returned from skl_pcode_request

If ret isn't zero, it is almost for sure ETIMEDOUT, because
we use it in wait_for macro which does continuous retries
until timeout is reached. If we still ran out of time and
retries, we most likely would be interested in getting status,
to understand what was the actual error propagated from PCode,
rather than to find out that we had a time out, which is anyway
quite obvious, if the function fails.

v2: Make it status ? status : ret(thanks Vinod for the hint)

Signed-off-by: Stanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Reviewed-by: Vinod Govindapillai <vinod.govindapillai@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20220411081343.18099-1-stanislav.lisovskiy@intel.com
drivers/gpu/drm/i915/intel_pcode.c