]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
xfs: prevent recursion in xfs_buf_iorequest
authorChristoph Hellwig <hch@infradead.org>
Mon, 2 Jul 2012 10:00:04 +0000 (06:00 -0400)
committerBen Myers <bpm@sgi.com>
Fri, 13 Jul 2012 18:09:39 +0000 (13:09 -0500)
commit40a9b7963df32e743c45d79a5f41445fe2476f15
treef764ef81befb876a05dc3166e8dfce1e057acba1
parentaa292847b9fc6e187547110de833a7d3131bbddf
xfs: prevent recursion in xfs_buf_iorequest

If the b_iodone handler is run in calling context in xfs_buf_iorequest we
can run into a recursion where xfs_buf_iodone_callbacks keeps calling back
into xfs_buf_iorequest because an I/O error happened, which keeps calling
back into xfs_buf_iorequest.  This chain will usually not take long
because the filesystem gets shut down because of log I/O errors, but even
over a short time it can cause stack overflows if run on the same context.

As a short term workaround make sure we always call the iodone handler in
workqueue context.

Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <dchinner@redhat.com>
Signed-off-by: Ben Myers <bpm@sgi.com>
fs/xfs/xfs_buf.c