]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc()
authorTariq Toukan <tariqt@mellanox.com>
Mon, 4 May 2020 08:36:02 +0000 (11:36 +0300)
committerDavid S. Miller <davem@davemloft.net>
Mon, 4 May 2020 17:42:06 +0000 (10:42 -0700)
commit40e473071dbad04316ddc3613c3a3d1c75458299
tree9642f9218c42aac49aeb9b14168b4648647d9d31
parentbea0c5c942d3b4e9fb6ed45f6a7de74c6b112437
net/mlx4_core: Fix use of ENOSPC around mlx4_counter_alloc()

When ENOSPC is set the idx is still valid and gets set to the global
MLX4_SINK_COUNTER_INDEX.  However gcc's static analysis cannot tell that
ENOSPC is impossible from mlx4_cmd_imm() and gives this warning:

drivers/net/ethernet/mellanox/mlx4/main.c:2552:28: warning: 'idx' may be
used uninitialized in this function [-Wmaybe-uninitialized]
 2552 |    priv->def_counter[port] = idx;

Also, when ENOSPC is returned mlx4_allocate_default_counters should not
fail.

Fixes: 6de5f7f6a1fa ("net/mlx4_core: Allocate default counter per port")
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
Signed-off-by: Tariq Toukan <tariqt@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/mellanox/mlx4/main.c