]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
pinctrl: samsung: Add of_node_put() before return in error path
authorNishka Dasgupta <nishkadg.linux@gmail.com>
Sun, 4 Aug 2019 16:02:00 +0000 (21:32 +0530)
committerMarcelo Henrique Cerri <marcelo.cerri@canonical.com>
Fri, 17 Jan 2020 17:22:45 +0000 (14:22 -0300)
commit40e58ca5f5824680811a19276d817cf33cdf6ba6
tree03a86446d80d4f30b5f2cab1f0988f20c7275107
parent8231a5bee2076873f277a689f697cffae9146e4a
pinctrl: samsung: Add of_node_put() before return in error path

BugLink: https://bugs.launchpad.net/bugs/1857158
commit 3d2557ab75d4c568c79eefa2e550e0d80348a6bd upstream.

Each iteration of for_each_child_of_node puts the previous node, but in
the case of a return from the middle of the loop, there is no put, thus
causing a memory leak. Hence add an of_node_put before the return of
exynos_eint_wkup_init() error path.
Issue found with Coccinelle.

Signed-off-by: Nishka Dasgupta <nishkadg.linux@gmail.com>
Cc: <stable@vger.kernel.org>
Fixes: 14c255d35b25 ("pinctrl: exynos: Add irq_chip instance for Exynos7 wakeup interrupts")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Kleber Sacilotto de Souza <kleber.souza@canonical.com>
drivers/pinctrl/samsung/pinctrl-exynos.c