]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
NFS: Fix an RCU lock leak in nfs4_refresh_delegation_stateid()
authorTrond Myklebust <trondmy@gmail.com>
Thu, 31 Oct 2019 22:40:33 +0000 (18:40 -0400)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 13 Nov 2019 23:47:34 +0000 (18:47 -0500)
commit4109dd5a8914ad958957df84229e8c00f7bb6cd8
tree542f7746215098ba072674947aee85921df441b8
parent203656a94ccbe6b0006b5500e32d22a6c330c672
NFS: Fix an RCU lock leak in nfs4_refresh_delegation_stateid()

BugLink: https://bugs.launchpad.net/bugs/1852492
commit 79cc55422ce99be5964bde208ba8557174720893 upstream.

A typo in nfs4_refresh_delegation_stateid() means we're leaking an
RCU lock, and always returning a value of 'false'. As the function
description states, we were always supposed to return 'true' if a
matching delegation was found.

Fixes: 12f275cdd163 ("NFSv4: Retry CLOSE and DELEGRETURN on NFS4ERR_OLD_STATEID.")
Cc: stable@vger.kernel.org # v4.15+
Signed-off-by: Trond Myklebust <trond.myklebust@hammerspace.com>
Signed-off-by: Anna Schumaker <Anna.Schumaker@Netapp.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
fs/nfs/delegation.c