]> git.proxmox.com Git - mirror_qemu.git/commit
load_elf: fix iterator's type for elf file processing
authorAnastasia Belova <abelova@astralinux.ru>
Mon, 15 Jan 2024 09:22:16 +0000 (12:22 +0300)
committerPeter Maydell <peter.maydell@linaro.org>
Thu, 18 Jan 2024 12:20:33 +0000 (12:20 +0000)
commit410c2a4d75f52f6a2fe978eda5a9b6f854afe5ea
tree337fef1005361ba17fd475e84198cc7ff823b4dd
parentc2d7faf713e04fc6b2d5b33d77cab0672c5bb30e
load_elf: fix iterator's type for elf file processing

j is used while loading an ELF file to byteswap segments'
data. If data is larger than 2GB an overflow may happen.
So j should be elf_word.

This commit fixes a minor bug: it's unlikely anybody is trying to
load ELF files with 2GB+ segments for wrong-endianness targets,
but if they did, it wouldn't work correctly.

Found by Linux Verification Center (linuxtesting.org) with SVACE.

Cc: qemu-stable@nongnu.org
Fixes: 7ef295ea5b ("loader: Add data swap option to load-elf")
Signed-off-by: Anastasia Belova <abelova@astralinux.ru>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
include/hw/elf_ops.h