]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
binder: use euid from cred instead of using task
authorTodd Kjos <tkjos@google.com>
Tue, 12 Oct 2021 16:56:12 +0000 (09:56 -0700)
committerAndrea Righi <andrea.righi@canonical.com>
Tue, 7 Dec 2021 06:32:24 +0000 (07:32 +0100)
commit4110173ce456f12656a60921c791918090bfb560
treea407dbec5ef89df165f872614328877d85f10b6b
parent4826097f9961ff4f45818b8cb6e52b67fee81fc4
binder: use euid from cred instead of using task

BugLink: https://bugs.launchpad.net/bugs/1950949
commit 29bc22ac5e5bc63275e850f0c8fc549e3d0e306b upstream.

Save the 'struct cred' associated with a binder process
at initial open to avoid potential race conditions
when converting to an euid.

Set a transaction's sender_euid from the 'struct cred'
saved at binder_open() instead of looking up the euid
from the binder proc's 'struct task'. This ensures
the euid is associated with the security context that
of the task that opened binder.

Cc: stable@vger.kernel.org # 4.4+
Fixes: 457b9a6f09f0 ("Staging: android: add binder driver")
Signed-off-by: Todd Kjos <tkjos@google.com>
Suggested-by: Stephen Smalley <stephen.smalley.work@gmail.com>
Suggested-by: Jann Horn <jannh@google.com>
Acked-by: Casey Schaufler <casey@schaufler-ca.com>
Signed-off-by: Paul Moore <paul@paul-moore.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Paolo Pisati <paolo.pisati@canonical.com>
drivers/android/binder.c
drivers/android/binder_internal.h