]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
usb: dwc2: Do not update data length if it is 0 on inbound transfers
authorGuenter Roeck <linux@roeck-us.net>
Wed, 13 Jan 2021 11:20:49 +0000 (12:20 +0100)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 26 Jan 2021 17:42:15 +0000 (18:42 +0100)
commit415fa1c7305dedbb345e2cc8ac91769bc1c83f1a
tree241528fb7ab1d329c61bb4cefa9a929f79dcb119
parent7961b77c0d489764166d789adb2c1d21b71b5aad
usb: dwc2: Do not update data length if it is 0 on inbound transfers

The DWC2 documentation states that transfers with zero data length should
set the number of packets to 1 and the transfer length to 0. This is not
currently the case for inbound transfers: the transfer length is set to
the maximum packet length. This can have adverse effects if the chip
actually does transfer data as it is programmed to do. Follow chip
documentation and keep the transfer length set to 0 in that situation.

Fixes: 56f5b1cff22a1 ("staging: Core files for the DWC2 driver")
Tested-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Reviewed-by: Douglas Anderson <dianders@chromium.org>
Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Nicolas Saenz Julienne <nsaenzjulienne@suse.de>
Link: https://lore.kernel.org/r/20210113112052.17063-2-nsaenzjulienne@suse.de
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/usb/dwc2/hcd.c