]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
PCI: designware: Check for iATU unroll support after initializing host
authorNiklas Cassel <niklas.cassel@axis.com>
Fri, 14 Oct 2016 21:54:55 +0000 (23:54 +0200)
committerBjorn Helgaas <bhelgaas@google.com>
Fri, 4 Nov 2016 20:28:55 +0000 (15:28 -0500)
commit416379f9ebded501eda882e6af0a7aafc1866700
tree7354377d7649f6e9d3bb5104593deddb9fc1ad92
parentad110449e285c75eb53357e87419a73c96ccb1b9
PCI: designware: Check for iATU unroll support after initializing host

dw_pcie_iatu_unroll_enabled() reads a dbi_base register.  Reading any
dbi_base register before pp->ops->host_init has been called causes
"imprecise external abort" on platforms like ARTPEC-6, where the PCIe
module is disabled at boot and first enabled in pp->ops->host_init.  Move
dw_pcie_iatu_unroll_enabled() to dw_pcie_setup_rc(), since it is after
pp->ops->host_init, but before pp->iatu_unroll_enabled is actually used.

Fixes: a0601a470537 ("PCI: designware: Add iATU Unroll feature")
Tested-by: James Le Cuirot <chewi@gentoo.org>
Signed-off-by: Niklas Cassel <niklas.cassel@axis.com>
Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Acked-by: Joao Pinto <jpinto@synopsys.com>
Acked-by: Olof Johansson <olof@lixom.net>
drivers/pci/host/pcie-designware.c