]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
net: ethernet: wiznet: Remove create_workqueue
authorBhaktipriya Shridhar <bhaktipriya96@gmail.com>
Wed, 1 Jun 2016 17:59:15 +0000 (23:29 +0530)
committerDavid S. Miller <davem@davemloft.net>
Thu, 2 Jun 2016 19:15:17 +0000 (12:15 -0700)
commit41cae08c76c60281a5a089e9c9dcc84803c3f43d
treecd850fbdbb6d0765422dbd4397eb393a87333a22
parentc8296b9aa79bd3e4ac580e273684d8ca137eb005
net: ethernet: wiznet: Remove create_workqueue

alloc_workqueue replaces deprecated create_workqueue().

A dedicated workqueue has been used since the workitems are involved
in normal device operation. Workitems &priv->rx_work and &priv->tx_work,
map to w5100_rx_work and w5100_tx_work respectively and are involved in
receiving and transmitting packets. Forward progress under
memory pressure is a requirement here.

create_workqueue has been replaced with alloc_workqueue with max_active
as 0 since there is no need for throttling the number of active work
items.

Since the driver may be used in memory reclaim path,
WQ_MEM_RECLAIM has been set to guarantee forward progress.

flush_workqueue is unnecessary since destroy_workqueue() itself calls
drain_workqueue() which flushes repeatedly till the workqueue
becomes empty. Hence the call to flush_workqueue() has been dropped.

Signed-off-by: Bhaktipriya Shridhar <bhaktipriya96@gmail.com>
Acked-by: Tejun Heo <tj@kernel.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/ethernet/wiznet/w5100.c