]> git.proxmox.com Git - mirror_ubuntu-hirsute-kernel.git/commit
tpm_crb: fix mapping of the buffers
authorJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Tue, 19 Apr 2016 09:54:18 +0000 (12:54 +0300)
committerJarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Sat, 25 Jun 2016 14:26:35 +0000 (17:26 +0300)
commit422eac3f7deae34dbaffd08e03e27f37a5394a56
tree2028523319b2534853d6e556c68f46b4f2f62bd3
parentddab0e34288a233ffd8763aa7c938d61ab128c0b
tpm_crb: fix mapping of the buffers

On my Lenovo x250 the following situation occurs:

[18697.813871] tpm_crb MSFT0101:00: can't request region for resource
[mem 0xacdff080-0xacdfffff]

The mapping of the control area overlaps the mapping of the command
buffer. The control area is mapped over page, which is not right. It
should mapped over sizeof(struct crb_control_area).

Fixing this issue unmasks another issue. Command and response buffers
can overlap and they do interleave on this machine. According to the PTP
specification the overlapping means that they are mapped to the same
buffer.

The commit has been also on a Haswell NUC where things worked before
applying this fix so that the both code paths for response buffer
initialization are tested.

Cc: stable@vger.kernel.org
Fixes: 1bd047be37d9 ("tpm_crb: Use devm_ioremap_resource")
Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@linux.intel.com>
Reviewed-by: Jason Gunthorpe <jgunthorpe@obsidianresearch.com>
drivers/char/tpm/tpm_crb.c