]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
crypto: s5p-sss - Close possible race for completed requests
authorKrzysztof Kozlowski <krzk@kernel.org>
Fri, 17 Mar 2017 14:49:19 +0000 (16:49 +0200)
committerHerbert Xu <herbert@gondor.apana.org.au>
Fri, 24 Mar 2017 14:03:00 +0000 (22:03 +0800)
commit42d5c176b76e190a4a3e0dfeffdae661755955b6
treedb6d2bd1e87eb5df0aea49129add8ee419e4ccc7
parentb189817cf7894e03fd3700acd923221d3007259e
crypto: s5p-sss - Close possible race for completed requests

Driver is capable of handling only one request at a time and it stores
it in its state container struct s5p_aes_dev.  This stored request must be
protected between concurrent invocations (e.g. completing current
request and scheduling new one).  Combination of lock and "busy" field
is used for that purpose.

When "busy" field is true, the driver will not accept new request thus
it will not overwrite currently handled data.

However commit 28b62b145868 ("crypto: s5p-sss - Fix spinlock recursion
on LRW(AES)") moved some of the write to "busy" field out of a lock
protected critical section.  This might lead to potential race between
completing current request and scheduling a new one.  Effectively the
request completion might try to operate on new crypto request.

Cc: <stable@vger.kernel.org> # v4.10.x
Fixes: 28b62b145868 ("crypto: s5p-sss - Fix spinlock recursion on LRW(AES)")
Signed-off-by: Krzysztof Kozlowski <krzk@kernel.org>
Reviewed-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
drivers/crypto/s5p-sss.c