]> git.proxmox.com Git - mirror_ubuntu-focal-kernel.git/commit
batman-adv: Drop immediate orig_node free function
authorSven Eckelmann <sven@narfation.org>
Tue, 5 Jan 2016 11:06:20 +0000 (12:06 +0100)
committerAntonio Quartulli <a@unstable.cc>
Sat, 16 Jan 2016 14:50:00 +0000 (22:50 +0800)
commit42eff6a617e23b691f8e4467f4687ed7245a92db
tree6d7d64bc6e77a67f067c87b1cc1c58d364738790
parentb4d922cfc9c08318eeb77d53b7633740e6b0efb0
batman-adv: Drop immediate orig_node free function

It is not allowed to free the memory of an object which is part of a list
which is protected by rcu-read-side-critical sections without making sure
that no other context is accessing the object anymore. This usually happens
by removing the references to this object and then waiting until the rcu
grace period is over and no one (allowedly) accesses it anymore.

But the _now functions ignore this completely. They free the object
directly even when a different context still tries to access it. This has
to be avoided and thus these functions must be removed and all functions
have to use batadv_orig_node_free_ref.

Fixes: 72822225bd41 ("batman-adv: Fix rcu_barrier() miss due to double call_rcu() in TT code")
Signed-off-by: Sven Eckelmann <sven@narfation.org>
Signed-off-by: Marek Lindner <mareklindner@neomailbox.ch>
Signed-off-by: Antonio Quartulli <a@unstable.cc>
net/batman-adv/originator.c
net/batman-adv/originator.h
net/batman-adv/translation-table.c