]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
drm/atomic: fix an error code in mode_fixup()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 7 Feb 2017 23:46:01 +0000 (02:46 +0300)
committerTim Gardner <tim.gardner@canonical.com>
Wed, 15 Mar 2017 15:32:11 +0000 (10:32 -0500)
commit4382e8551105fe8bf7dc5a0b19585b98556abca2
tree6dbfe3ad9d3b516a99e37389934ea57edb40afc5
parentc5c89c2ad8c7cdb030e4cc1de6fb5cefcc985871
drm/atomic: fix an error code in mode_fixup()

BugLink: http://bugs.launchpad.net/bugs/1673118
commit f9ad86e42d0303eeb8e0d41bb208153022ebd9d2 upstream.

Having "ret" be a bool type works for everything except
ret = funcs->atomic_check().  The other functions all return zero on
error but ->atomic_check() returns negative error codes.  We want to
propagate the error code but instead we return 1.

I found this bug with static analysis and I don't know if it affects
run time.

Fixes: 4cd4df8080a3 ("drm/atomic: Add ->atomic_check() to encoder helpers")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Daniel Vetter <daniel.vetter@ffwll.ch>
Link: http://patchwork.freedesktop.org/patch/msgid/20170207234601.GA23981@mwanda
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
drivers/gpu/drm/drm_atomic_helper.c