]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
ARM: dts: rockchip: explicitly set vcc_sd0 pin to gpio on rk3188-radxarock
authorHeiko Stuebner <heiko@sntech.de>
Thu, 20 Sep 2018 09:34:36 +0000 (11:34 +0200)
committerStefan Bader <stefan.bader@canonical.com>
Tue, 26 Nov 2019 12:16:47 +0000 (13:16 +0100)
commit4383d3cea32e42aeacc39e4c5e9b80685e4bf1d1
treebcf722e983b3dbe80b60145f37e09b5322c68b73
parent2096023d68499cf19ead1566e3c0c8129bba33ac
ARM: dts: rockchip: explicitly set vcc_sd0 pin to gpio on rk3188-radxarock

BugLink: https://bugs.launchpad.net/bugs/1853915
[ Upstream commit a2df0984e73fd9e1dad5fc3f1c307ec3de395e30 ]

It is good practice to make the setting of gpio-pinctrls explicitly in the
devicetree, and in this case even necessary.
Rockchip boards start with iomux settings set to gpio for most pins and
while the linux pinctrl driver also implicitly sets the gpio function if
a pin is requested as gpio that is not necessarily true for other drivers.

The issue in question stems from uboot, where the sdmmc_pwr pin is set
to function 1 (sdmmc-power) by the bootrom when reading the 1st-stage
loader. The regulator controlled by the pin is active-low though, so
when the dwmmc hw-block sets its enabled bit, it actually disables the
regulator. By changing the pin back to gpio we fix that behaviour.

Signed-off-by: Heiko Stuebner <heiko@sntech.de>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
arch/arm/boot/dts/rk3188-radxarock.dts