]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl
authorViktor Slavkovic <viktors@google.com>
Mon, 8 Jan 2018 18:43:03 +0000 (10:43 -0800)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Tue, 9 Jan 2018 14:32:11 +0000 (15:32 +0100)
commit443064cb0b1fb4569fe0a71209da7625129fb760
tree677f623bbda77dd2fddb27de05169668d250e0cd
parent30a7acd573899fd8b8ac39236eff6468b195ac7d
staging: android: ashmem: fix a race condition in ASHMEM_SET_SIZE ioctl

A lock-unlock is missing in ASHMEM_SET_SIZE ioctl which can result in a
race condition when mmap is called. After the !asma->file check, before
setting asma->size, asma->file can be set in mmap. That would result in
having different asma->size than the mapped memory size. Combined with
ASHMEM_UNPIN ioctl and shrinker invocation, this can result in memory
corruption.

Signed-off-by: Viktor Slavkovic <viktors@google.com>
Cc: stable@vger.kernel.org
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/staging/android/ashmem.c