]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
drm/vmwgfx: Fix two list_for_each loop exit tests
authorDan Carpenter <dan.carpenter@oracle.com>
Fri, 26 Jun 2020 10:39:59 +0000 (13:39 +0300)
committerRoland Scheidegger <sroland@vmware.com>
Tue, 11 Aug 2020 01:16:02 +0000 (03:16 +0200)
commit4437c1152ce0e57ab8f401aa696ea6291cc07ab1
treefb42b630996b00470a37d568b0726cef8c3c1bdd
parent1d2c0c565bc0da25f5e899a862fb58e612b222df
drm/vmwgfx: Fix two list_for_each loop exit tests

These if statements are supposed to be true if we ended the
list_for_each_entry() loops without hitting a break statement but they
don't work.

In the first loop, we increment "i" after the "if (i == unit)" condition
so we don't necessarily know that "i" is not equal to unit at the end of
the loop.

In the second loop we exit when mode is not pointing to a valid
drm_display_mode struct so it doesn't make sense to check "mode->type".

Fixes: a278724aa23c ("drm/vmwgfx: Implement fbdev on kms v2")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Roland Scheidegger <sroland@vmware.com>
Signed-off-by: Roland Scheidegger <sroland@vmware.com>
drivers/gpu/drm/vmwgfx/vmwgfx_kms.c