]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
virtio: don't always force a notification when ring is full
authorRusty Russell <rusty@rustcorp.com.au>
Fri, 25 Jul 2008 17:06:04 +0000 (12:06 -0500)
committerRusty Russell <rusty@rustcorp.com.au>
Fri, 25 Jul 2008 02:06:04 +0000 (12:06 +1000)
commit44653eae1407f79dff6f52fcf594ae84cb165ec4
tree9c8f356f6c294678a05dbc983e60b8b5d864b7bc
parent674bfc23c585b34c42263d73fb51710d49762a23
virtio: don't always force a notification when ring is full

We force notification when the ring is full, even if the host has
indicated it doesn't want to know.  This seemed like a good idea at
the time: if we fill the transmit ring, we should tell the host
immediately.

Unfortunately this logic also applies to the receiving ring, which is
refilled constantly.  We should introduce real notification thesholds
to replace this logic.  Meanwhile, removing the logic altogether breaks
the heuristics which KVM uses, so we use a hack: only notify if there are
outgoing parts of the new buffer.

Here are the number of exits with lguest's crappy network implementation:
Before:
network xmit 7859051 recv 236420
After:
network xmit 7858610 recv 118136

Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
drivers/virtio/virtio_ring.c