]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
mm: memcontrol: do not uncharge old page in page cache replacement
authorJohannes Weiner <hannes@cmpxchg.org>
Wed, 20 Jan 2016 23:03:16 +0000 (15:03 -0800)
committerLinus Torvalds <torvalds@linux-foundation.org>
Thu, 21 Jan 2016 01:09:18 +0000 (17:09 -0800)
commit44b7a8d33d666268062e0f725d5f14813a63a6ea
tree976a8ef6d69e8d34be1b07ec5f5d75e26b291ceb
parent3e24b19dd5ff0587674ac7578cc11ef079708327
mm: memcontrol: do not uncharge old page in page cache replacement

Changing page->mem_cgroup of a live page is tricky and fragile.  In
particular, the memcg writeback code relies on that mapping being stable
and users of mem_cgroup_replace_page() not overlapping with dirtyable
inodes.

Page cache replacement doesn't have to do that, though.  Instead of being
clever and transferring the charge from the old page to the new,
force-charge the new page and leave the old page alone.  A temporary
overcharge won't matter in practice, and the old page is going to be freed
shortly after this anyway.  And this is not performance critical.

Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>
Cc: Michal Hocko <mhocko@suse.cz>
Cc: Vladimir Davydov <vdavydov@virtuozzo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
mm/memcontrol.c