]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
net_sched: pfifo_head_drop problem
authorEric Dumazet <eric.dumazet@gmail.com>
Wed, 5 Jan 2011 10:35:02 +0000 (10:35 +0000)
committerDavid S. Miller <davem@davemloft.net>
Wed, 5 Jan 2011 21:39:17 +0000 (13:39 -0800)
commit44b8288308ac9da27eab7d7bdbf1375a568805c3
tree47fc194f0ff73d2fdb7d62d3d8d6d268ca660316
parentdbbe68bb12b34f3e450da7a73c20e6fa1f85d63a
net_sched: pfifo_head_drop problem

commit 57dbb2d83d100ea (sched: add head drop fifo queue)
introduced pfifo_head_drop, and broke the invariant that
sch->bstats.bytes and sch->bstats.packets are COUNTER (increasing
counters only)

This can break estimators because est_timer() handles unsigned deltas
only. A decreasing counter can then give a huge unsigned delta.

My mid term suggestion would be to change things so that
sch->bstats.bytes and sch->bstats.packets are incremented in dequeue()
only, not at enqueue() time. We also could add drop_bytes/drop_packets
and provide estimations of drop rates.

It would be more sensible anyway for very low speeds, and big bursts.
Right now, if we drop packets, they still are accounted in byte/packets
abolute counters and rate estimators.

Before this mid term change, this patch makes pfifo_head_drop behavior
similar to other qdiscs in case of drops :
Dont decrement sch->bstats.bytes and sch->bstats.packets

Signed-off-by: Eric Dumazet <eric.dumazet@gmail.com>
Acked-by: Hagen Paul Pfeifer <hagen@jauu.net>
Signed-off-by: David S. Miller <davem@davemloft.net>
net/sched/sch_fifo.c