]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
blk-mq: clear active_queues before clearing BLK_MQ_F_TAG_QUEUE_SHARED
authorYu Kuai <yukuai3@huawei.com>
Sat, 31 Jul 2021 06:21:30 +0000 (14:21 +0800)
committerJens Axboe <axboe@kernel.dk>
Fri, 13 Aug 2021 14:01:34 +0000 (08:01 -0600)
commit454bb6775202d94f0f489c4632efecdb62d3c904
tree8ce5feb20b9e7782dc17e192e8507ef5aa719846
parent0f78399551146bfbed357759e2ad5abb8d39e50a
blk-mq: clear active_queues before clearing BLK_MQ_F_TAG_QUEUE_SHARED

We run a test that delete and recover devcies frequently(two devices on
the same host), and we found that 'active_queues' is super big after a
period of time.

If device a and device b share a tag set, and a is deleted, then
blk_mq_exit_queue() will clear BLK_MQ_F_TAG_QUEUE_SHARED because there
is only one queue that are using the tag set. However, if b is still
active, the active_queues of b might never be cleared even if b is
deleted.

Thus clear active_queues before BLK_MQ_F_TAG_QUEUE_SHARED is cleared.

Signed-off-by: Yu Kuai <yukuai3@huawei.com>
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Link: https://lore.kernel.org/r/20210731062130.1533893-1-yukuai3@huawei.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
block/blk-mq.c