]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
bus: mhi: host: pci_generic: Drop redundant pci_enable_pcie_error_reporting()
authorBjorn Helgaas <bhelgaas@google.com>
Tue, 7 Mar 2023 20:16:25 +0000 (14:16 -0600)
committerManivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Wed, 8 Mar 2023 05:29:23 +0000 (10:59 +0530)
commit45581e663703b7d36da1bc884950f199976bc8b3
tree7f654808335b5f729cf4637d952ae0bd46ba6ec0
parent94e19f4fbb1efc21cab860723662b3a9228b428f
bus: mhi: host: pci_generic: Drop redundant pci_enable_pcie_error_reporting()

pci_enable_pcie_error_reporting() enables the device to send ERR_*
Messages.  Since commit <f26e58bf6f54> ("PCI/AER: Enable error reporting
when AER is native"), the PCI core does this for all devices during
enumeration, so the driver doesn't need to do it itself.

Remove the redundant pci_enable_pcie_error_reporting() call from the
driver.  Also remove the corresponding pci_disable_pcie_error_reporting()
from the driver .remove() path.

Note that this only controls ERR_* Messages from the device.  An ERR_*
Message may cause the Root Port to generate an interrupt, depending on the
AER Root Error Command register managed by the AER service driver.

Signed-off-by: Bjorn Helgaas <bhelgaas@google.com>
Reviewed-by: Manivannan Sadhasivam <mani@kernel.org>
Reviewed-by: Jeffrey Hugo <quic_jhugo@quicinc.com>
Link: https://lore.kernel.org/r/20230307201625.879567-1-helgaas@kernel.org
Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
drivers/bus/mhi/host/pci_generic.c