]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
mac80211: consider QoS Null frames for STA_NULLFUNC_ACKED
authorThomas Pedersen <thomas@adapt-ip.com>
Tue, 19 Nov 2019 05:35:38 +0000 (21:35 -0800)
committerKhalid Elmously <khalid.elmously@canonical.com>
Wed, 29 Jan 2020 04:45:21 +0000 (23:45 -0500)
commit45a6f1a764312021aa3a05fc9ae7e8fd944cf601
tree47982af6065f8550bac947d57f1c1b80c7bd0f22
parentbdb6c31d56b4447f7457ec6bae172d24b7475eb6
mac80211: consider QoS Null frames for STA_NULLFUNC_ACKED

BugLink: https://bugs.launchpad.net/bugs/1859712
[ Upstream commit 08a5bdde3812993cb8eb7aa9124703df0de28e4b ]

Commit 7b6ddeaf27ec ("mac80211: use QoS NDP for AP probing")
let STAs send QoS Null frames as PS triggers if the AP was
a QoS STA.  However, the mac80211 PS stack relies on an
interface flag IEEE80211_STA_NULLFUNC_ACKED for
determining trigger frame ACK, which was not being set for
acked non-QoS Null frames. The effect is an inability to
trigger hardware sleep via IEEE80211_CONF_PS since the QoS
Null frame was seemingly never acked.

This bug only applies to drivers which set both
IEEE80211_HW_REPORTS_TX_ACK_STATUS and
IEEE80211_HW_PS_NULLFUNC_STACK.

Detect the acked QoS Null frame to restore STA power save.

Fixes: 7b6ddeaf27ec ("mac80211: use QoS NDP for AP probing")
Signed-off-by: Thomas Pedersen <thomas@adapt-ip.com>
Link: https://lore.kernel.org/r/20191119053538.25979-4-thomas@adapt-ip.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Khalid Elmously <khalid.elmously@canonical.com>
net/mac80211/status.c