]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
blk-mq: don't touch ->tagset in blk_mq_get_sq_hctx
authorMing Lei <ming.lei@redhat.com>
Sun, 22 May 2022 12:23:50 +0000 (20:23 +0800)
committerStefan Bader <stefan.bader@canonical.com>
Fri, 26 Aug 2022 08:52:45 +0000 (10:52 +0200)
commit45b971bcaea63ef54bc8a1259ee33b58fedc3c9c
treed5045eec4d716d376e3467a69837dadd34fbe841
parent2c5475243d8d907f5af3bb8b6ec2bb3b34b1906c
blk-mq: don't touch ->tagset in blk_mq_get_sq_hctx

BugLink: https://bugs.launchpad.net/bugs/1982968
[ Upstream commit 5d05426e2d5fd7df8afc866b78c36b37b00188b7 ]

blk_mq_run_hw_queues() could be run when there isn't queued request and
after queue is cleaned up, at that time tagset is freed, because tagset
lifetime is covered by driver, and often freed after blk_cleanup_queue()
returns.

So don't touch ->tagset for figuring out current default hctx by the mapping
built in request queue, so use-after-free on tagset can be avoided. Meantime
this way should be fast than retrieving mapping from tagset.

Cc: "yukuai (C)" <yukuai3@huawei.com>
Cc: Jan Kara <jack@suse.cz>
Fixes: b6e68ee82585 ("blk-mq: Improve performance of non-mq IO schedulers with multiple HW queues")
Signed-off-by: Ming Lei <ming.lei@redhat.com>
Reviewed-by: Jan Kara <jack@suse.cz>
Link: https://lore.kernel.org/r/20220522122350.743103-1-ming.lei@redhat.com
Signed-off-by: Jens Axboe <axboe@kernel.dk>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
block/blk-mq.c