]> git.proxmox.com Git - mirror_ubuntu-bionic-kernel.git/commit
IB/mlx5: Fix mlx5_ib_alloc_mr error flow
authorNitzan Carmi <nitzanc@mellanox.com>
Tue, 26 Dec 2017 09:20:20 +0000 (11:20 +0200)
committerJason Gunthorpe <jgg@mellanox.com>
Wed, 27 Dec 2017 22:24:41 +0000 (15:24 -0700)
commit45e6ae7ef21b907dacb18da62d5787d74a31d860
treedd45067d1c1a85ae3061f2f86c98b9f96469e8c4
parent4a50881bbac309e6f0684816a180bc3c14e1485d
IB/mlx5: Fix mlx5_ib_alloc_mr error flow

ibmr.device is being set only after ib_alloc_mr() is
(successfully) complete. Therefore, in case mlx5_core_create_mkey()
return with error, the error flow calls mlx5_free_priv_descs()
which uses ibmr.device (which doesn't exist yet), causing
a NULL dereference oops.

To fix this, the IB device should be set in the mr struct earlier
stage (e.g. prior to calling mlx5_core_create_mkey()).

Fixes: 8a187ee52b04 ("IB/mlx5: Support the new memory registration API")
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Nitzan Carmi <nitzanc@mellanox.com>
Signed-off-by: Leon Romanovsky <leon@kernel.org>
Signed-off-by: Jason Gunthorpe <jgg@mellanox.com>
drivers/infiniband/hw/mlx5/mr.c