]> git.proxmox.com Git - mirror_ubuntu-eoan-kernel.git/commit
ipv6: add complete rcu protection around np->opt
authorEric Dumazet <edumazet@google.com>
Mon, 30 Nov 2015 03:37:57 +0000 (19:37 -0800)
committerDavid S. Miller <davem@davemloft.net>
Thu, 3 Dec 2015 04:37:16 +0000 (23:37 -0500)
commit45f6fad84cc305103b28d73482b344d7f5b76f39
tree283dbc3a6cd4a26288a3526d0de48cf8c2e27b75
parent01b3f52157ff5a47d6d8d796f396a4b34a53c61d
ipv6: add complete rcu protection around np->opt

This patch addresses multiple problems :

UDP/RAW sendmsg() need to get a stable struct ipv6_txoptions
while socket is not locked : Other threads can change np->opt
concurrently. Dmitry posted a syzkaller
(http://github.com/google/syzkaller) program desmonstrating
use-after-free.

Starting with TCP/DCCP lockless listeners, tcp_v6_syn_recv_sock()
and dccp_v6_request_recv_sock() also need to use RCU protection
to dereference np->opt once (before calling ipv6_dup_options())

This patch adds full RCU protection to np->opt

Reported-by: Dmitry Vyukov <dvyukov@google.com>
Signed-off-by: Eric Dumazet <edumazet@google.com>
Acked-by: Hannes Frederic Sowa <hannes@stressinduktion.org>
Signed-off-by: David S. Miller <davem@davemloft.net>
13 files changed:
include/linux/ipv6.h
include/net/ipv6.h
net/dccp/ipv6.c
net/ipv6/af_inet6.c
net/ipv6/datagram.c
net/ipv6/exthdrs.c
net/ipv6/inet6_connection_sock.c
net/ipv6/ipv6_sockglue.c
net/ipv6/raw.c
net/ipv6/syncookies.c
net/ipv6/tcp_ipv6.c
net/ipv6/udp.c
net/l2tp/l2tp_ip6.c