]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
regmap: Do not call regcache_exit from regcache_rbtree_init error path
authorLars-Peter Clausen <lars@metafoo.de>
Tue, 15 Nov 2011 12:34:40 +0000 (13:34 +0100)
committerMark Brown <broonie@opensource.wolfsonmicro.com>
Tue, 15 Nov 2011 19:22:59 +0000 (19:22 +0000)
commit462a185c5cea7063348003c1644b70a6f6780f01
treeea7bac0e1c53a745fc41e12142cadf6b334d42bf
parentbd061c78cabc28bb64ed79f784d24918b6bdb791
regmap: Do not call regcache_exit from regcache_rbtree_init error path

Calling regcache_exit from regcache_rbtree_init is first of all a layering
violation and secondly will cause double frees. regcache_exit will free buffers
allocated by the core, but the core will also free the same buffers when the
cacheops init callback returns an error. Thus we end up with a double free.
Fix this by not calling regcache_exit but only free those buffers which, have
been allocated in this function.

Signed-off-by: Lars-Peter Clausen <lars@metafoo.de>
Acked-by: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
Signed-off-by: Mark Brown <broonie@opensource.wolfsonmicro.com>
drivers/base/regmap/regcache-rbtree.c