]> git.proxmox.com Git - mirror_ubuntu-jammy-kernel.git/commit
scsi: qla2xxx: Simplify conditional check again
authorNathan Chancellor <natechancellor@gmail.com>
Tue, 26 Mar 2019 22:04:46 +0000 (15:04 -0700)
committerMartin K. Petersen <martin.petersen@oracle.com>
Thu, 28 Mar 2019 01:28:15 +0000 (21:28 -0400)
commit46333cebe77883ff38be59c3e7200c5a5145d6ee
tree5a1179ac58820da2a5b8b7a6e4aa1060589b9e9d
parentd16ece577bf2cee7f94bab75a0d967bcb89dd2a7
scsi: qla2xxx: Simplify conditional check again

Clang warns when it sees a logical not on the left side of a conditional
statement because it thinks the logical not should be applied to the whole
statement, not just the left side:

drivers/scsi/qla2xxx/qla_nx.c:3703:7: warning: logical not is only
applied to the left hand side of this comparison
[-Wlogical-not-parentheses]

This particular instance was already fixed by commit 0bfe7d3cae58 ("scsi:
qla2xxx: Simplify conditional check") upstream but it was reintroduced by
commit 3695310e37b4 ("scsi: qla2xxx: Update flash read/write routine") in
the 5.2/scsi-queue.

Fixes: 3695310e37b4 ("scsi: qla2xxx: Update flash read/write routine")
Link: https://github.com/ClangBuiltLinux/linux/issues/80
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Nick Desaulniers <ndesaulniers@google.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
drivers/scsi/qla2xxx/qla_nx.c