]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
s390: qeth: address type mismatch warning
authorArnd Bergmann <arnd@arndb.de>
Thu, 25 Apr 2019 16:25:54 +0000 (18:25 +0200)
committerDavid S. Miller <davem@davemloft.net>
Fri, 26 Apr 2019 15:14:06 +0000 (11:14 -0400)
commit46b83629dede262315aa82179d105581f11763b6
tree1a87ed97171d56e6132b14665f92bc610a3bfc0a
parent9157bc2a5e8214b29f1f64342e7a3aae93a98512
s390: qeth: address type mismatch warning

clang produces a harmless warning for each use for the qeth_adp_supported
macro:

drivers/s390/net/qeth_l2_main.c:559:31: warning: implicit conversion from enumeration type 'enum qeth_ipa_setadp_cmd' to
      different enumeration type 'enum qeth_ipa_funcs' [-Wenum-conversion]
        if (qeth_adp_supported(card, IPA_SETADP_SET_PROMISC_MODE))
            ~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~
drivers/s390/net/qeth_core.h:179:41: note: expanded from macro 'qeth_adp_supported'
        qeth_is_ipa_supported(&c->options.adp, f)
        ~~~~~~~~~~~~~~~~~~~~~                  ^

Add a version of this macro that uses the correct types, and
remove the unused qeth_adp_enabled() macro that has the same
problem.

Reviewed-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Signed-off-by: Julian Wiedmann <jwi@linux.ibm.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/s390/net/qeth_core.h