]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
mm: Allow architectures to request 'old' entries when prefaulting
authorWill Deacon <will@kernel.org>
Tue, 24 Nov 2020 18:48:26 +0000 (18:48 +0000)
committerWill Deacon <will@kernel.org>
Wed, 20 Jan 2021 14:46:04 +0000 (14:46 +0000)
commit46bdb4277f98e70d0c91f4289897ade533fe9e80
tree886459a47676a6092a022b7a37ea27495d771819
parentf9ce0be71d1fbb038ada15ced83474b0e63f264d
mm: Allow architectures to request 'old' entries when prefaulting

Commit 5c0a85fad949 ("mm: make faultaround produce old ptes") changed
the "faultaround" behaviour to initialise prefaulted PTEs as 'old',
since this avoids vmscan wrongly assuming that they are hot, despite
having never been explicitly accessed by userspace. The change has been
shown to benefit numerous arm64 micro-architectures (with hardware
access flag) running Android, where both application launch latency and
direct reclaim time are significantly reduced (by 10%+ and ~80%
respectively).

Unfortunately, commit 315d09bf30c2 ("Revert "mm: make faultaround
produce old ptes"") reverted the change due to it being identified as
the cause of a ~6% regression in unixbench on x86. Experiments on a
variety of recent arm64 micro-architectures indicate that unixbench is
not affected by the original commit, which appears to yield a 0-1%
performance improvement.

Since one size does not fit all for the initial state of prefaulted
PTEs, introduce arch_wants_old_prefaulted_pte(), which allows an
architecture to opt-in to 'old' prefaulted PTEs at runtime based on
whatever criteria it may have.

Cc: Jan Kara <jack@suse.cz>
Cc: Minchan Kim <minchan@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Reported-by: Vinayak Menon <vinmenon@codeaurora.org>
Signed-off-by: Will Deacon <will@kernel.org>
include/linux/mm.h
mm/filemap.c
mm/memory.c