]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
selftests: rtnetlink: Fix do_test_address_proto()
authorPetr Machata <petrm@nvidia.com>
Wed, 29 Mar 2023 15:24:53 +0000 (17:24 +0200)
committerJakub Kicinski <kuba@kernel.org>
Fri, 31 Mar 2023 06:21:56 +0000 (23:21 -0700)
commit46e9acb7ae2a36643b8c43f5107c072cbbc48572
tree09309c155c59a3db8947d4db0be53502e17a95ea
parent3292004c90c8aba74600a5cd8d10f8186fd48269
selftests: rtnetlink: Fix do_test_address_proto()

This selftest was introduced recently in the commit cited below. It misses
several check_err() invocations to actually verify that the previous
command succeeded. When these are added, the first one fails, because
besides the addresses added by hand, there can be a link-local address
added by the kernel. Adjust the check to expect at least three addresses
instead of exactly three, and add the missing check_err's.

Furthermore, the explanatory comments assume that the address with no
protocol is $addr2, when in fact it is $addr3. Update the comments.

Fixes: 6a414fd77f61 ("selftests: rtnetlink: Add an address proto test")
Signed-off-by: Petr Machata <petrm@nvidia.com>
Reviewed-by: Ido Schimmel <idosch@nvidia.com>
Link: https://lore.kernel.org/r/53a579bc883e1bf2fe490d58427cf22c2d1aa21f.1680102695.git.petrm@nvidia.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
tools/testing/selftests/net/rtnetlink.sh