]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
ASoC: SOF: ipc3-topology: Make sure that only one cmd is sent in dai_config
authorPeter Ujfalusi <peter.ujfalusi@linux.intel.com>
Fri, 12 May 2023 11:03:17 +0000 (14:03 +0300)
committerMark Brown <broonie@kernel.org>
Mon, 15 May 2023 01:21:12 +0000 (10:21 +0900)
commit4708449eafe60742334606168926985798c9c9b8
tree17919033d07d2788f5a425f82c052f351937dc07
parentf63550e2b165208a2f382afcaf5551df9569e1d4
ASoC: SOF: ipc3-topology: Make sure that only one cmd is sent in dai_config

The commands in sof_ipc_dai_config.flags are encoded as bits:
1 (bit0) - hw_params
2 (bit1) - hw_free
4 (bit2) - pause

These are commands, they cannot be combined as one would assume, for
example
3 (bit0 | bit1) is invalid.

This can happen right at the second start of a stream as at the end of the
first stream we set the hw_free command (bit1) and on the second start we
would OR on top of it the hw_params (bit0).

Fixes: b66bfc3a9810 ("ASoC: SOF: sof-audio: Fix broken early bclk feature for SSP")
Signed-off-by: Peter Ujfalusi <peter.ujfalusi@linux.intel.com
Reviewed-by: Daniel Baluta <daniel.baluta@nxp.com
Reviewed-by: Bard Liao <yung-chuan.liao@linux.intel.com
Reviewed-by: Ranjani Sridharan <ranjani.sridharan@linux.intel.com
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com
Link: https://lore.kernel.org/r/20230512110317.5180-1-peter.ujfalusi@linux.intel.com
Signed-off-by: Mark Brown <broonie@kernel.org
sound/soc/sof/ipc3-topology.c