]> git.proxmox.com Git - mirror_ubuntu-zesty-kernel.git/commit
mfd: 88pm80x: Double shifting bug in suspend/resume
authorDan Carpenter <dan.carpenter@oracle.com>
Thu, 4 Aug 2016 05:26:56 +0000 (08:26 +0300)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 8 Nov 2016 16:44:21 +0000 (16:44 +0000)
commit472957d13e3c5aa24be52079483070259a43c2a1
tree2acb3646c9bd0e8f98545a4d4ab7fcefa17f5b67
parent337a861bb70ddf43e29fa1e4604206a36aa6e6f2
mfd: 88pm80x: Double shifting bug in suspend/resume

BugLink: http://bugs.launchpad.net/bugs/1634153
commit 9a6dc644512fd083400a96ac4a035ac154fe6b8d upstream.

set_bit() and clear_bit() take the bit number so this code is really
doing "1 << (1 << irq)" which is a double shift bug.  It's done
consistently so it won't cause a problem unless "irq" is more than 4.

Fixes: 70c6cce04066 ('mfd: Support 88pm80x in 80x driver')
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Lee Jones <lee.jones@linaro.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Tim Gardner <tim.gardner@canonical.com>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
include/linux/mfd/88pm80x.h