]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
IB/core: Fix bit curruption in ib_device_cap_flags structure
authorMax Gurtovoy <maxg@mellanox.com>
Mon, 6 Jun 2016 16:34:39 +0000 (19:34 +0300)
committerDoug Ledford <dledford@redhat.com>
Tue, 7 Jun 2016 13:50:54 +0000 (09:50 -0400)
commit47355b3cd7d3c9c5226bff7c449b9d269fb17fa6
treeab1241f9498ab51391dc645b2998b9c857e1ebe1
parent8aec013afe6d9665eb478396026ebd4384dbe934
IB/core: Fix bit curruption in ib_device_cap_flags structure

ib_device_cap_flags 64-bit expansion caused caps overlapping
and made consumers read wrong device capabilities. For example
IB_DEVICE_SG_GAPS_REG was falsely read by the iser driver causing
it to use a non-existing capability. This happened because signed
int becomes sign extended when converted it to u64. Fix this by
casting IB_DEVICE_ON_DEMAND_PAGING enumeration to ULL.

Fixes: f5aa9159a418 ('IB/core: Add arbitrary sg_list support')
Reported-by: Robert LeBlanc <robert@leblancnet.us>
Cc: Stable <stable@vger.kernel.org> #[v4.6+]
Acked-by: Sagi Grimberg <sagi@grimberg.me>
Signed-off-by: Max Gurtovoy <maxg@mellanox.com>
Signed-off-by: Matan Barak <matanb@mellanox.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Doug Ledford <dledford@redhat.com>
include/rdma/ib_verbs.h