]> git.proxmox.com Git - mirror_ubuntu-kernels.git/commit
can/at91: don't check platform_get_irq's return value against zero
authorUwe Kleine-König <u.kleine-koenig@pengutronix.de>
Sat, 19 Dec 2009 04:31:56 +0000 (20:31 -0800)
committerDavid S. Miller <davem@davemloft.net>
Sat, 19 Dec 2009 04:31:56 +0000 (20:31 -0800)
commit4773a47d8a564633cd80b94df397e91e946893e2
tree2ac03e9459394f59bd0953a78eb13cd67a6562f2
parent01a1e7ec6c3769dc7c5fde23ebc253c6be5f68eb
can/at91: don't check platform_get_irq's return value against zero

platform_get_irq returns -ENXIO on failure, so !irq was probably
always true.  Better use (int)irq <= 0.  Note that a return value of
zero is still handled as error even though this could mean irq0.

This is a followup to 305b3228f9ff4d59f49e6d34a7034d44ee8ce2f0 that
changed the return value of platform_get_irq from 0 to -ENXIO on error.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Wolfgang Grandegger <wg@grandegger.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
drivers/net/can/at91_can.c