]> git.proxmox.com Git - mirror_ubuntu-artful-kernel.git/commit
mm: fix RODATA_TEST failure "rodata_test: test data was not read only"
authorChristophe Leroy <christophe.leroy@c-s.fr>
Tue, 3 Oct 2017 23:15:16 +0000 (16:15 -0700)
committerSeth Forshee <seth.forshee@canonical.com>
Thu, 19 Oct 2017 14:48:57 +0000 (09:48 -0500)
commit477bc499fb493e6c0f75bcce06c117621ceaa469
tree56c0df15b7f161c7bd0347eecb743f2bfb10a54a
parent5cc96a7b00ea66673e19e834ff949e70770cd06f
mm: fix RODATA_TEST failure "rodata_test: test data was not read only"

BugLink: http://bugs.launchpad.net/bugs/1723145
commit a872eb2131e91ce7c89a8888974a5e22a272b12f upstream.

On powerpc, RODATA_TEST fails with message the following messages:

  Freeing unused kernel memory: 528K
  rodata_test: test data was not read only

This is because GCC allocates it to .data section:

  c0695034 g     O .data 00000004 rodata_test_data

Since commit 056b9d8a7692 ("mm: remove rodata_test_data export, add
pr_fmt"), rodata_test_data is used only inside rodata_test.c By
declaring it static, it gets properly allocated into .rodata section
instead of .data:

  c04df710 l     O .rodata 00000004 rodata_test_data

Fixes: 056b9d8a7692 ("mm: remove rodata_test_data export, add pr_fmt")
Link: http://lkml.kernel.org/r/20170921093729.1080368AC1@po15668-vm-win7.idsi0.si.c-s.fr
Signed-off-by: Christophe Leroy <christophe.leroy@c-s.fr>
Cc: Kees Cook <keescook@chromium.org>
Cc: Jinbum Park <jinb.park7@gmail.com>
Cc: Segher Boessenkool <segher@kernel.crashing.org>
Cc: David Laight <David.Laight@ACULAB.COM>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Seth Forshee <seth.forshee@canonical.com>
mm/rodata_test.c